feat: support parallelstore csi driver #2203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
apeabody
requested changes
Dec 10, 2024
autogen/main/variables.tf.tmpl
Outdated
| variable "parallelstore_csi_driver" { | ||
| type = bool | ||
| description = "Whether the Parallelstore CSI driver Addon is enabled for this cluster." | ||
| default = false |
There was a problem hiding this comment.
As there is a dynamic block using a for_each, could the default be made null so this is optional?
| @@ -388,6 +388,14 @@ resource "google_container_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "parallelstore_csi_driver_config" { | |||
There was a problem hiding this comment.
I don't think we need to add for Autopilot clusters as for them it's enabled by default?
There was a problem hiding this comment.
Only found this as ref, will go with not setting this on autopilot for now
DrFaust92
force-pushed
the
parallelstore
branch
from
0786e17 to
9a0011c
Compare
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
force-pushed
the
parallelstore
branch
from
9a0011c to
4db1d92
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.